[aapit]

Thanks for your reply.
I’ve solved it in the meantime.
As far as I can see, it was caused by not having the mbstring PHP extension.

Add New Note to this Reply

[aapit]

…okay, that escape wasn’t working either, sorry – now attaching the HTML block as a text file.

Attachments:

You must be logged in to view attached files.

Add New Note to this Reply

[aapit]

…I should have escaped the HTML block that I was quoting, here it is again:

<div>
/*&lt;!--[CDATA[*/<div><div></div><div><p>39 op voorraad</p></div>/*]]&gt;*/</div>

Add New Note to this Reply

[aapit]

Since the latest update, I’ve confirmed that I cannot translate everything by .mo/.po files. I had to manually do the update in the theme again.

I’m referring to the “I’ve read and accept the Terms & conditions” text here:
wp-content/themes/loja/woocommerce/checkout/payment.php:51

I’ve tried in various ways, how should I translate that in a .po file?

The same happens in the SiteSao core plugin:
“Shopping Cart” (in sidebar, when the shopping cart is filled)
wp-content/plugins/sitesao-core/includes/woocommerce.php:346

Perhaps I’m missing something, I appreciate your help. Thanks.

Add New Note to this Reply

[aapit]

Hi Dh,

Thanks for your reply. I understand why you’ve chosen this, although I think it’s not an optimal solution to hardcode stuff just to make it pass for a validator plugin.
Anyway, the workaround works for me – so my problem is solved for now. I don’t think it will work for multilingual sites, though. So it would be good to have a more durable solution.

Thanks! Regards.

Add New Note to this Reply

[aapit]

Hi Dh,

Thanks. The site is not open for the public yet, unfortunately.
It won’t be a problem for me to make the font size bigger, I can tweak that myself.
Personally I think it would be a better idea to place the message *above* the form, instead of below. I guess that would be a more difficult change, right?
If you have tips for that, it would be great, otherwise never mind – it’s not a showstopper.

Add New Note to this Reply

[aapit]

Thanks, @reezah, good to hear it’s working now!

@dh: I’m still interested in hearing why this strategy of using overriding strings was chosen. Especially the hardcoded ones I mentioned. I was considering using other SiteSao themes for some future projects, but this makes me doubt whether that is such a wise choice for us.

Add New Note to this Reply

[aapit]

Hey @reezah,

I was able to translate the strings you highlighted in the language files.
Mind you, you do need to translate the sitesao-core language files as well. In my case, this resulted in:
wp-content/plugins/sitesao-core/languages/sitesao-nl_NL.po (and .mo)

Also, make sure WordPress has access to the files, so read and execute permissions should be the same as the en_US.* files of SiteSao-core and Loja.

And don’t forget a hard refresh in your browser, or use an incognito window just to be sure. Those are all the pitfalls I can think of right now.

Good luck!

Add New Note to this Reply

[aapit]

@reezah: I’ve translated them all by now, but it was quite a fuss.
You need to translate both the language files in the sitesao-core plugin, and other strings are to be found in the language files of the Loja theme. Unfortunately one needs to look in both files, because you can’t really know which is where without looking in the source.

Then there were two strings that were not translatable through either language file, but are apparently just hardcoded. This is a bad thing, SiteSao!

@reezah, they can be found here, and for now I just translated them in the theme and plugin – which is obviously not a durable solution.

– “I’ve read and accept the Terms & conditions”
wp-content/themes/loja/woocommerce/checkout/payment.php:51

– “Shopping Cart”
(in the sidebar / mini cart, when there is something in the shopping cart)
wp-content/plugins/sitesao-core/includes/woocommerce.php:346

Instead of paying users helping other paying users out, an update for the theme would obviously be a better solution… Just saying.

Add New Note to this Reply

[aapit]

Hello,

Thanks for your reply. I’ve managed starting to translate some of the terms.
I don’t understand why the theme overrides these perfectly fine translations. It seems a bit silly that the translations works fine in lots of free themes, and that I have to go through all kinds of fuss to make it work for a paid theme, even though there’s nothing wrong with the WooCommerce native translations. I don’t see the added value in overriding basic terms like ‘Search’. Why is this?

Add New Note to this Reply